Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove setup.cfg files, other packaging cleanup #544

Open
wants to merge 1 commit into
base: branch-25.02
Choose a base branch
from
Open

remove setup.cfg files, other packaging cleanup #544

wants to merge 1 commit into from

Conversation

jameslamb
Copy link
Member

Similar to rapidsai/raft#2532, this proposes some small packaging cleanup.

  • removes setup.cfg files
    • these are currently being ignored by tools, in favor of identical configuration in pyproject.toml and .flake8 files
    • e.g.

      cuvs/.pre-commit-config.yaml

      Lines 31 to 35 in b3ce774

      hooks:
      - id: mypy
      additional_dependencies: [types-cachetools]
      args: ["--config-file=pyproject.toml",
      "python/cuvs/cuvs"]
  • alphabetizes dependency lists in dependencies.yaml
  • changes cupy: group in dependencies.yaml to depends_on_cupy: (for consistency with other dependencies)

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 18, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 18, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Member Author

/ok to test

@jameslamb jameslamb changed the title WIP: remove setup.cfg files, other packaging cleanup remove setup.cfg files, other packaging cleanup Dec 20, 2024
@jameslamb jameslamb marked this pull request as ready for review December 20, 2024 14:56
@jameslamb jameslamb requested review from a team as code owners December 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/packaging-codeowners

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jameslamb